[PATCH v1] rtc: rtc-asm9260: Switch to use dev_err_probe()

Yang Ruibin 11162571 at vivo.com
Wed Aug 28 05:25:07 PDT 2024


use dev_err_probe() instead of dev_err() to simplify the error path and
standardize the format of the error code.

Signed-off-by: Yang Ruibin <11162571 at vivo.com>
---
 drivers/rtc/rtc-asm9260.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c
index a83b47e0d..2b7058ebb 100644
--- a/drivers/rtc/rtc-asm9260.c
+++ b/drivers/rtc/rtc-asm9260.c
@@ -268,10 +268,8 @@ static int asm9260_rtc_probe(struct platform_device *pdev)
 		return PTR_ERR(priv->clk);
 
 	ret = clk_prepare_enable(priv->clk);
-	if (ret) {
-		dev_err(dev, "Failed to enable clk!\n");
-		return ret;
-	}
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to prepare clk!\n");
 
 	ccr = ioread32(priv->iobase + HW_CCR);
 	/* if dev is not enabled, reset it */
-- 
2.34.1




More information about the linux-arm-kernel mailing list