[PATCH 1/6] net: driver: stmmac: extend CSR calc support

[Jan Petrous (OSS)]

> -----Original Message-----
> From: Andrew Lunn <andrew at lunn.ch>
> Sent: Monday, 5 August, 2024 1:11
> To: Jan Petrous (OSS) <jan.petrous at oss.nxp.com>
> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>; Alexandre Torgue
> <alexandre.torgue at foss.st.com>; dl-S32 <S32 at nxp.com>; linux-
> kernel at vger.kernel.org; linux-stm32 at st-md-mailman.stormreply.com; linux-
> arm-kernel at lists.infradead.org; Claudiu Manoil <claudiu.manoil at nxp.com>;
> netdev at vger.kernel.org
> Subject: Re: [PATCH 1/6] net: driver: stmmac: extend CSR calc support
> 
> >  #define	STMMAC_CSR_20_35M	0x2	/* MDC = clk_scr_i/16 */
> >  #define	STMMAC_CSR_35_60M	0x3	/* MDC = clk_scr_i/26 */
> >  #define	STMMAC_CSR_150_250M	0x4	/* MDC =
> clk_scr_i/102 */
> > -#define	STMMAC_CSR_250_300M	0x5	/* MDC =
> clk_scr_i/122 */
> > +#define	STMMAC_CSR_250_300M	0x5	/* MDC =
> clk_scr_i/124 */
> 
> That should probably be called out in the commit message. It is not a
> fix as such, since it is just a comment, but as a reviewer i had a
> double take when i noticed this.,
> 

Will add the note to the commit message in v2.

/Jan