[PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform
Potthuri, Sai Krishna
sai.krishna.potthuri at amd.com
Tue Aug 13 09:01:59 PDT 2024
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Tuesday, August 13, 2024 3:45 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri at amd.com>; Linus Walleij
> <linus.walleij at linaro.org>; Simek, Michal <michal.simek at amd.com>; Rob
> Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt at linaro.org>; Conor Dooley <conor+dt at kernel.org>;
> Buddhabhatti, Jay <jay.buddhabhatti at amd.com>; Kundanala, Praveen Teja
> <praveen.teja.kundanala at amd.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>
> Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> linux-gpio at vger.kernel.org; devicetree at vger.kernel.org;
> saikrishna12468 at gmail.com; git (AMD-Xilinx) <git at amd.com>
> Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal
> platform
>
> On 13/08/2024 07:40, Potthuri, Sai Krishna wrote:
> >> sd1_wp_0_grp, sd1_wp_1_grp,
> >>> + ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,
> >> qspi0_fbclk_0_grp, qspi0_ss_0_grp,
> >>> + test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
> >>> + maxItems: 78
> >>
> >> You miss minItems... I have doubts this was really tested.
> > groups/pins are mentioned as required property.
> > Do we still need to define minItems?
>
> These are two unrelated concepts. How many items can be listed at once in
> each property?
In this case, minItem should be 1, my understanding is since property is
mentioned as required, minItem: 1 is an implicit consideration.
Please correct me if my understanding is wrong.
Regards
Sai Krishna
More information about the linux-arm-kernel
mailing list