[PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Tue Aug 13 03:14:39 PDT 2024
On 13/08/2024 07:40, Potthuri, Sai Krishna wrote:
>> sd1_wp_0_grp, sd1_wp_1_grp,
>>> + ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,
>> qspi0_fbclk_0_grp, qspi0_ss_0_grp,
>>> + test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
>>> + maxItems: 78
>>
>> You miss minItems... I have doubts this was really tested.
> groups/pins are mentioned as required property.
> Do we still need to define minItems?
These are two unrelated concepts. How many items can be listed at once
in each property?
>
> ....
>
>>> +
>>> + drive-strength:
>>
>> drive-strength-microamp
> In this case, values are in mA.
Ah, no, if it is mA, then existing property is correct.
> Do we still need to use drive-strength-microamp?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list