[PATCH v5 04/10] ARM: mm: Type-annotate all cache assembly routines

Russell King (Oracle) linux at armlinux.org.uk
Mon Apr 29 06:18:28 PDT 2024


On Mon, Apr 15, 2024 at 03:43:23PM +0200, Linus Walleij wrote:
> -ENTRY(fa_flush_user_cache_all)
> -	/* FALLTHROUGH */
> +SYM_TYPED_FUNC_START(fa_flush_user_cache_all)
> +	b	fa_flush_kern_cache_all
> +SYM_FUNC_END(fa_flush_user_cache_all)

The thing I don't like about this is that it makes these functions
less efficient - the early CPUs do _not_ have branch predictors,
and they flush the pipeline on branches, so rather than just dropping
rough, this kind of thing introduces pointless multi-cycle delays for
functionality just to keep CFI happy.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!



More information about the linux-arm-kernel mailing list