[PATCH v5 04/10] ARM: mm: Type-annotate all cache assembly routines

Linus Walleij linus.walleij at linaro.org
Tue Apr 16 00:38:31 PDT 2024


On Mon, Apr 15, 2024 at 6:35 PM Ard Biesheuvel <ardb at kernel.org> wrote:

> > -ENTRY(fa_flush_user_cache_all)
> > -       /* FALLTHROUGH */
> > +SYM_TYPED_FUNC_START(fa_flush_user_cache_all)
> > +       b       fa_flush_kern_cache_all
> > +SYM_FUNC_END(fa_flush_user_cache_all)
> > +
>
> Given that the prototypes are identical (and therefore compatible as
> far as kCFI is concerned), we might just define an alias
>
> SYM_FUNC_ALIAS(fa_flush_user_cache_all, fa_flush_kern_cache_all)
>
> rather than generate different code.

Now we are getting to the real meat of the review :)

I will comb over both annotation patches and make sure to use
SYM_FUNC_ALIAS() where applicable, it seems a good number of
sites can be simplified this way.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list