[PATCH 2/5] iommu/arm-smmu-v3: Enable HTTU for stage1 with io-pgtable mapping
Jason Gunthorpe
jgg at nvidia.com
Wed Nov 29 11:30:50 PST 2023
On Tue, Nov 28, 2023 at 09:49:37AM +0000, Shameer Kolothum wrote:
> /* IOMMU API */
> static bool arm_smmu_capable(struct device *dev, enum iommu_cap cap)
> {
> @@ -2401,6 +2413,10 @@ static int arm_smmu_domain_finalise(struct arm_smmu_domain *smmu_domain,
> .iommu_dev = smmu->dev,
> };
>
> + if (arm_smmu_dbm_capable(smmu) &&
> + smmu_domain->stage == ARM_SMMU_DOMAIN_S1)
> + pgtbl_cfg.quirks |= IO_PGTABLE_QUIRK_ARM_HD;
> +
This flow has become a bit wonky, the switch statement right above is
already checking S1 and partially initializing pgtbl_cfg.
I suggest moving the pgtbl_cfg init to above the switch and making the
switch store directly into pgtbl_cfg values and remove the stack ios
and oas values
Regards,
Jason
More information about the linux-arm-kernel
mailing list