[PATCH 0/2] staging: vc04_services: Use %p to log pointer
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Thu Nov 23 05:14:10 PST 2023
On Tue, Nov 07, 2023 at 11:55:21AM -0500, Umang Jain wrote:
> %lx is used to print the unmodified pointer address for debugging.
> %p will print the hashed pointer address to avoid leaking information
> about kernel memory layout to userspace. But when `no_hash_pointers`
> is passed as kernel parameter, unmodified pointer address will be
> printed.
>
> Hence, drop %lx in favour of %p. For debugging purposes, one can
> easily depend on `no_hash_pointers`.
>
> This also solves the following smatch warnings:
> service_callback() warn: argument 7 to %lx specifier is cast from pointer
> service_callback() warn: argument 11 to %lx specifier is cast from pointer
> service_callback() warn: argument 12 to %lx specifier is cast from pointer
> service_callback() warn: argument 13 to %lx specifier is cast from pointer
> vchiq_release() warn: argument 7 to %lx specifier is cast from pointer
Doesn't apply as I didn't take your other patch series. resend it when
you have that one fixed up?
thanks,
greg k-h
More information about the linux-arm-kernel
mailing list