[PATCH 2/2] staging: vc04_services: Use %p to log pointer address

Umang Jain umang.jain at ideasonboard.com
Tue Nov 7 08:55:23 PST 2023


Solves the following Smatch warnings:
vchiq_dev.c:1220 vchiq_release() warn: argument 7 to %lx specifier is cast from pointer

%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
index a64d6333cf0a..16e951b2570f 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
@@ -1217,9 +1217,9 @@ static int vchiq_release(struct inode *inode, struct file *file)
 	int ret = 0;
 	int i;
 
-	dev_dbg(state->dev, "%s: %s: %s: instance=%lx\n",
+	dev_dbg(state->dev, "%s: %s: %s: instance=%p\n",
 		log_cat(VCHIQ_ARM), log_type(DEBUG),
-		__func__, (unsigned long)instance);
+		__func__, instance);
 
 	if (!state) {
 		ret = -EPERM;
-- 
2.41.0




More information about the linux-arm-kernel mailing list