[PATCH] arm64: Make the ARCH_FORCE_MAX_ORDER config input prompt unconditional

Ard Biesheuvel ardb at kernel.org
Wed May 3 08:41:19 PDT 2023


On Wed, 3 May 2023 at 17:36, Justin Forbes <jforbes at fedoraproject.org> wrote:
>
> On Wed, May 3, 2023 at 7:33 AM Catalin Marinas <catalin.marinas at arm.com> wrote:
> >
> > Commit 34affcd7577a ("arm64: drop ranges in definition of
> > ARCH_FORCE_MAX_ORDER") dropped the ranges from the config entry and
> > introduced an EXPERT condition on the input prompt instead. This change
> > may affect some distro kernels that change ARCH_FORCE_MAX_ORDER but do
> > not want to enable EXPERT.
> >
> > Drop EXPERT from the input prompt together with the (ARM64_4K_PAGES ||
> > ARM64_16K_PAGES) condition as the latter no longer makes sense after the
> > ranges were removed. The latter makes all the page size configurations
> > consistent w.r.t. ARCH_FORCE_MAX_ORDER.
> >
> > Fixes: 34affcd7577a ("arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER")
> > Signed-off-by: Catalin Marinas <catalin.marinas at arm.com>
> > Reported-by: Justin M. Forbes <jforbes at fedoraproject.org>
> > Cc: Will Deacon <will at kernel.org>
> > Cc: Mike Rapoport <rppt at kernel.org>
> > Cc: Andrew Morton <akpm at linux-foundation.org>
>
> This works for me, thanks.
>
> Acked-by: Justin M. Forbes <jforbes at fedoraproject.org>
>

I'd still be interested in gaining a better understanding as to why
Fedora/RHEL think they need to change this value on arm64. In
particular, whether it is to support ThunderX, or whether there are
any good reasons for doing so that we are unaware of.



More information about the linux-arm-kernel mailing list