[PATCH] arm64: Make the ARCH_FORCE_MAX_ORDER config input prompt unconditional

Justin Forbes jforbes at fedoraproject.org
Wed May 3 08:35:10 PDT 2023


On Wed, May 3, 2023 at 7:33 AM Catalin Marinas <catalin.marinas at arm.com> wrote:
>
> Commit 34affcd7577a ("arm64: drop ranges in definition of
> ARCH_FORCE_MAX_ORDER") dropped the ranges from the config entry and
> introduced an EXPERT condition on the input prompt instead. This change
> may affect some distro kernels that change ARCH_FORCE_MAX_ORDER but do
> not want to enable EXPERT.
>
> Drop EXPERT from the input prompt together with the (ARM64_4K_PAGES ||
> ARM64_16K_PAGES) condition as the latter no longer makes sense after the
> ranges were removed. The latter makes all the page size configurations
> consistent w.r.t. ARCH_FORCE_MAX_ORDER.
>
> Fixes: 34affcd7577a ("arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER")
> Signed-off-by: Catalin Marinas <catalin.marinas at arm.com>
> Reported-by: Justin M. Forbes <jforbes at fedoraproject.org>
> Cc: Will Deacon <will at kernel.org>
> Cc: Mike Rapoport <rppt at kernel.org>
> Cc: Andrew Morton <akpm at linux-foundation.org>

This works for me, thanks.

Acked-by: Justin M. Forbes <jforbes at fedoraproject.org>

>  arch/arm64/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index b1201d25a8a4..1867aba83ba3 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1516,7 +1516,7 @@ config XEN
>  # 16K |       27          |      14      |       13        |         11         |
>  # 64K |       29          |      16      |       13        |         13         |
>  config ARCH_FORCE_MAX_ORDER
> -       int "Order of maximal physically contiguous allocations" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES)
> +       int "Order of maximal physically contiguous allocations"
>         default "13" if ARM64_64K_PAGES
>         default "11" if ARM64_16K_PAGES
>         default "10"
>



More information about the linux-arm-kernel mailing list