[PATCH v2 1/2] media: imx: imx7-media-csi: Fix mbus framefmt field init

Rui Miguel Silva rmfrfs at gmail.com
Tue Mar 21 08:00:13 PDT 2023


Hi Alexander,

Alexander Stein <alexander.stein at ew.tq-group.com> writes:

> 'field' is zero-initialized to V4L2_FIELD_ANY, which is an invalid value
> to return to userspace. Instead fefault to non-interleaving.
>
> Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>

Many thanks for adding this much better change log. (with the already
mention fefault fix from Laurent :) )

Reviewed-by: Rui Miguel Silva <rmfrfs at gmail.com>

Cheers,
   Rui
> ---
>  drivers/media/platform/nxp/imx7-media-csi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c
> index c22bf5c827e7..3e97b9f2ff69 100644
> --- a/drivers/media/platform/nxp/imx7-media-csi.c
> +++ b/drivers/media/platform/nxp/imx7-media-csi.c
> @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct imx7_csi *csi)
>  	format.code = IMX7_CSI_DEF_MBUS_CODE;
>  	format.width = IMX7_CSI_DEF_PIX_WIDTH;
>  	format.height = IMX7_CSI_DEF_PIX_HEIGHT;
> +	format.field = V4L2_FIELD_NONE;
>  
>  	imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL);
>  	csi->vdev_compose.width = format.width;
> -- 
> 2.34.1



More information about the linux-arm-kernel mailing list