[PATCH v2 1/2] media: imx: imx7-media-csi: Fix mbus framefmt field init

[Alexander Stein]

Hi Laurent,

Am Dienstag, 21. März 2023, 10:37:57 CET schrieb Laurent Pinchart:
> Hi Alexander,
> 
> Thank you for the patch.
> 
> On Tue, Mar 21, 2023 at 08:27:06AM +0100, Alexander Stein wrote:
> > 'field' is zero-initialized to V4L2_FIELD_ANY, which is an invalid value
> > to return to userspace. Instead fefault to non-interleaving.
> 
> I prefer defaulting to non-interleaving instead of fefaulting :-) I'll
> fix the typo in my tree.

Oh :-) thanks for fixing this.

Best regards,
Alexander

> > Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> > ---
> > 
> >  drivers/media/platform/nxp/imx7-media-csi.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c
> > b/drivers/media/platform/nxp/imx7-media-csi.c index
> > c22bf5c827e7..3e97b9f2ff69 100644
> > --- a/drivers/media/platform/nxp/imx7-media-csi.c
> > +++ b/drivers/media/platform/nxp/imx7-media-csi.c
> > @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct
> > imx7_csi *csi)> 
> >  	format.code = IMX7_CSI_DEF_MBUS_CODE;
> >  	format.width = IMX7_CSI_DEF_PIX_WIDTH;
> >  	format.height = IMX7_CSI_DEF_PIX_HEIGHT;
> > 
> > +	format.field = V4L2_FIELD_NONE;
> > 
> >  	imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL);
> >  	csi->vdev_compose.width = format.width;


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/