[PATCH v2] spi: Use dev_err_probe instead of dev_err

Markus Elfring Markus.Elfring at web.de
Thu Jul 27 01:35:15 PDT 2023


> > It is possible that dma_request_chan will return EPROBE_DEFER,
> > which means that dev is not ready yet. In this case,
> > dev_err(dev), there will be no output. This patch fixes the bug.
…
> This looks reasonable, though could you use the same prefix that was
> used for previous changes:
>
> spi: bcm2835: Use dev_err_probe instead of dev_err
>
> with that done, please add a:
>
> Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>

* How appropriate is your presentation of this tag “in advance”?

* Would you like to take another look at the properties for
  the reviewer's statement of oversight?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n542


I would also appreciate another improved imperative change description.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94

Regards,
Markus



More information about the linux-arm-kernel mailing list