[PATCH v2] spi: Use dev_err_probe instead of dev_err

Florian Fainelli florian.fainelli at broadcom.com
Wed Jul 26 08:02:10 PDT 2023



On 7/26/2023 3:54 AM, Wang Ming wrote:
> It is possible that dma_request_chan will return EPROBE_DEFER,
> which means that dev is not ready yet. In this case,
> dev_err(dev), there will be no output. This patch fixes the bug.
> 
> Signed-off-by: Wang Ming <machel at vivo.com>

This looks reasonable, though could you use the same prefix that was 
used for previous changes:

spi: bcm2835: Use dev_err_probe instead of dev_err

with that done, please add a:

Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>
-- 
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20230726/30f679ee/attachment-0001.p7s>


More information about the linux-arm-kernel mailing list