[PATCH v3 1/4] dt-bindings: mfd: Add nxp bbnsm

[Jacky Bai]

> Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Add nxp bbnsm
> 
> On Tue, Jan 03, 2023 at 03:47:39PM +0800, Jacky Bai wrote:
> > Add binding for NXP BBNSM(Battery-Backed Non-Secure Module).
> >
> > Signed-off-by: Jacky Bai <ping.bai at nxp.com>
> > ---
> >   - v2 changes:
> >     - remove the redundant 'bindings' string
> >     - add ref to rtc.yaml
> >     - add start-year property
> >     - rename 'regmap' to 'nxp,bbnsm-regmap' and add description & type
> define
> >     - add header files including in the example and correct the
> > indentation
> >
> >   -v3 changes:
> >     - remove the 'nxp,bbnsm-regmap' property, get the regmap directly
> from the
> >       parent node in rtc/pwrkey driver
> > ---
> >  .../devicetree/bindings/mfd/nxp,bbnsm.yaml    | 99
> +++++++++++++++++++
> >  1 file changed, 99 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> > b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> > new file mode 100644
> > index 000000000000..bcd8fbc6e297
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> > @@ -0,0 +1,99 @@

...

> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - nxp,bbnsm
> 
> Is this a standalone device or block in an SoC. In the latter case, this needs to
> be SoC specific.

it is an IP block in SoC, currently used on NXP i.MX SoC. I will change it to SoC specific in v4.

BR
> 
> > +      - const: syscon
> > +      - const: simple-mfd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  rtc:
> > +    type: object
> > +    $ref: /schemas/rtc/rtc.yaml#
> > +
> > +    properties:
> > +      compatible:
> > +        const: nxp,bbnsm-rtc
> > +
> > +      interrupts:
> > +        maxItems: 1
> > +
> > +      start-year: true
> > +
> > +    required:
> > +      - compatible
> > +      - interrupts
> > +
> > +    additionalProperties: false
> > +
> > +  pwrkey:
> > +    type: object
> > +    $ref: /schemas/input/input.yaml#
> > +
> > +    properties:
> > +      compatible:
> > +        const: nxp,bbnsm-pwrkey
> > +
> > +      interrupts:
> > +        maxItems: 1
> > +
> > +      linux,code: true
> > +
> > +    required:
> > +      - compatible
> > +      - interrupts
> > +
> > +    additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - rtc
> > +  - pwrkey
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/input/linux-event-codes.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    bbnsm: bbnsm at 44440000 {
> > +        compatible = "nxp,bbnsm", "syscon", "simple-mfd";
> > +        reg = <0x44440000 0x10000>;
> > +
> > +        bbnsm_rtc: rtc {
> > +            compatible = "nxp,bbnsm-rtc";
> > +            interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > +        };
> > +
> > +        bbnsm_pwrkey: pwrkey {
> > +            compatible = "nxp,bbnsm-pwrkey";
> > +            interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > +            linux,code = <KEY_POWER>;
> > +        };
> > +    };
> > --
> > 2.37.1
> >
> >