[PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Fri Jan 6 01:24:05 PST 2023


On 06/01/2023 10:18, Lucas Stach wrote:
> Am Donnerstag, dem 05.01.2023 um 15:41 +0100 schrieb Marek Vasut:
>> Swap the SAI dmas and dma-names to match the order documented in
>> Documentation/devicetree/bindings/sound/fsl,sai.yaml
>> No functional change.
>>
> While I'm not opposing this patch, I find this class of changes a bit
> odd. The *-names properties are there so the properties they are naming
> can be in any order in the DT without impacting the lookup. Enforcing a
> fixed order for named properties just feels odd.

DT requires fixed order regardless of '-names' property. '-names' are
not there to fulfill "can be in any order", but merely a helper.

> 
> Not sure if the schema validation could take this into account or if
> there is any policy in place already by the DT maintainer that we still
> want to enforce the same order in the DTs as in the bindings.

The order in DTS must obviously match bindings, however here both are
changed, so what is exactly your concern?


Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list