[PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order

[Lucas Stach]

Am Donnerstag, dem 05.01.2023 um 15:41 +0100 schrieb Marek Vasut:
> Swap the SAI dmas and dma-names to match the order documented in
> Documentation/devicetree/bindings/sound/fsl,sai.yaml
> No functional change.
> 
While I'm not opposing this patch, I find this class of changes a bit
odd. The *-names properties are there so the properties they are naming
can be in any order in the DT without impacting the lookup. Enforcing a
fixed order for named properties just feels odd.

Not sure if the schema validation could take this into account or if
there is any policy in place already by the DT maintainer that we still
want to enforce the same order in the DTs as in the bindings.

Regards,
Lucas

> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: Adam Ford <aford173 at gmail.com>
> Cc: Alexander Stein <alexander.stein at ew.tq-group.com>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: Joakim Zhang <qiangqing.zhang at nxp.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Cc: Liam Girdwood <lgirdwood at gmail.com>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Mark Brown <broonie at kernel.org>
> Cc: Markus Niebel <Markus.Niebel at ew.tq-group.com>
> Cc: NXP Linux Team <linux-imx at nxp.com>
> Cc: Paul Elder <paul.elder at ideasonboard.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Pengutronix Kernel Team <kernel at pengutronix.de>
> Cc: Richard Cochran <richardcochran at gmail.com>
> Cc: Richard Zhu <hongxing.zhu at nxp.com>
> Cc: Rob Herring <robh+dt at kernel.org>
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Shawn Guo <shawnguo at kernel.org>
> Cc: Shengjiu Wang <shengjiu.wang at nxp.com>
> Cc: Stefan Agner <stefan at agner.ch>
> Cc: Tim Harvey <tharvey at gateworks.com>
> Cc: alsa-devel at alsa-project.org
> Cc: devicetree at vger.kernel.org
> To: linux-arm-kernel at lists.infradead.org
> ---
>  arch/arm/boot/dts/vfxxx.dtsi | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index d53f9c9db8bfd..ff4479994b600 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -191,9 +191,8 @@ sai0: sai at 4002f000 {
>  					<&clks VF610_CLK_SAI0_DIV>,
>  					<&clks 0>, <&clks 0>;
>  				clock-names = "bus", "mclk1", "mclk2", "mclk3";
> -				dma-names = "tx", "rx";
> -				dmas = <&edma0 0 17>,
> -					<&edma0 0 16>;
> +				dma-names = "rx", "tx";
> +				dmas = <&edma0 0 16>, <&edma0 0 17>;
>  				status = "disabled";
>  			};
>  
> @@ -205,9 +204,8 @@ sai1: sai at 40030000 {
>  					<&clks VF610_CLK_SAI1_DIV>,
>  					<&clks 0>, <&clks 0>;
>  				clock-names = "bus", "mclk1", "mclk2", "mclk3";
> -				dma-names = "tx", "rx";
> -				dmas = <&edma0 0 19>,
> -					<&edma0 0 18>;
> +				dma-names = "rx", "tx";
> +				dmas = <&edma0 0 18>, <&edma0 0 19>;
>  				status = "disabled";
>  			};
>  
> @@ -219,9 +217,8 @@ sai2: sai at 40031000 {
>  					<&clks VF610_CLK_SAI2_DIV>,
>  					<&clks 0>, <&clks 0>;
>  				clock-names = "bus", "mclk1", "mclk2", "mclk3";
> -				dma-names = "tx", "rx";
> -				dmas = <&edma0 0 21>,
> -					<&edma0 0 20>;
> +				dma-names = "rx", "tx";
> +				dmas = <&edma0 0 20>, <&edma0 0 21>;
>  				status = "disabled";
>  			};
>  
> @@ -233,9 +230,8 @@ sai3: sai at 40032000 {
>  					<&clks VF610_CLK_SAI3_DIV>,
>  					<&clks 0>, <&clks 0>;
>  				clock-names = "bus", "mclk1", "mclk2", "mclk3";
> -				dma-names = "tx", "rx";
> -				dmas = <&edma0 1 9>,
> -					<&edma0 1 8>;
> +				dma-names = "rx", "tx";
> +				dmas = <&edma0 1 8>, <&edma0 1 9>;
>  				status = "disabled";
>  			};
>