[PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset

Brad Larson blarson at amd.com
Mon Feb 6 17:51:48 PST 2023


On Thu, Jan 19, 2023, at 09:57, Arnd Bergmann wrote:
> On Thu, Jan 19, 2023, at 04:39, Brad Larson wrote:
>> 
>> +extern unsigned int sdhci_timeout_val;
>> +
>
> This declaration should not be in the .c file, and I don't think
> there should be a global variable with this overly generic name either.

Thanks for pointing this out, I've deleted that line.  It was leftover test
code to force a timeout to trigger the reset driver and reset the timeout.

Regards,
Brad



More information about the linux-arm-kernel mailing list