[PATCH 3/3] perf vendor events arm64: Use event name instead of event code

shangxiaojing shangxiaojing at huawei.com
Fri Oct 21 03:31:28 PDT 2022



On 2022/10/21 17:09, James Clark wrote:
> 
> 
>>       {
>> -        "MetricExpr": "armv8_pmuv3_0 at event\\=0x7002@ / CPU_CYCLES",
>> +        "MetricExpr": "EXE_STALL_DIV / CPU_CYCLES",
>>           "PublicDescription": "Divider L3 topdown metric",
>>           "BriefDescription": "Divider L3 topdown metric",
>>           "MetricGroup": "TopDownL3",
>>           "MetricName": "divider"
>>       },
>>       {
>> -        "MetricExpr": "armv8_pmuv3_0 at event\\=0x7003@ / CPU_CYCLES",
>> +        "MetricExpr": "FSU_STALL / CPU_CYCLES",
>>           "PublicDescription": "FSU stall L3 topdown metric",
>> -        "BriefDescription": "FSU stall L3 topdown metric",
>> +	"BriefDescription": "FSU stall L3 topdown metric",
> 
> There is a tab here, but it's probably not worth resubmitting over.
> 
> Otherwise for the whole set:
> 
> Acked-by: James Clark <james.clark at arm.com>

Thanks for the review, will fix in v2.

Thanks,
-- 
Shang XiaoJing



More information about the linux-arm-kernel mailing list