[PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Mon Nov 21 08:15:30 PST 2022
On 21/11/2022 15:48, Tony Lindgren wrote:
> * Uwe Kleine-König <u.kleine-koenig at pengutronix.de> [221121 14:30]:
>> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote:
>>> Let's allow node numbering in decimal format too.
>>>
>>> Simple human-readable increments/IDs are usually decimal, hex is only for
>>> addresses as noted by Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>.
>>>
>>> Cc: Thierry Reding <thierry.reding at gmail.com>
>>> Cc: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>>> Signed-off-by: Tony Lindgren <tony at atomide.com>
>>> ---
>>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
>>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
>>> @@ -13,7 +13,7 @@ select: false
>>>
>>> properties:
>>> $nodename:
>>> - pattern: "^pwm(@.*|-[0-9a-f])*$"
>>> + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$"
>>
>> I wonder why you don't make this:
>>
>> + pattern: "^pwm(@.*|-[0-9a-f]*)$"
Yes, the '*' should be within ().
>
> Hmm but I think this would also pass for node names like pwm-a-foo?
>
No, how?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list