[PATCH v4 2/8] arm64/fpsimd: Track the saved FPSIMD state type separately to TIF_SVE

[Mark Brown]

On Sun, Nov 13, 2022 at 10:12:12PM +0000, Catalin Marinas wrote:
> On Sat, Oct 22, 2022 at 12:03:15AM +0100, Mark Brown wrote:

> > +enum fp_type {
> > +	FP_STATE_FPSIMD,
> > +	FP_STATE_SVE,
> > +};

> More of a nitpick, I still find the type/state naming confusing but I
> don't have a better suggestion. Maybe call them FP_TYPE_* or rename the
> enum to fp_state_type (up to you really, feel free to leave them as they
> are).

Yeah, the naming is kind of awkward and I'm not a massive fan
either.  I think whatever name is chosen will end up being
awkward in some circumstance.  No problem with renaming if
someone has a firm thought that some specific thing would be
better though.

> Either way, I think having an explicit type of what state is about is a
> significant improvement in clarity.

> Reviewed-by: Catalin Marinas <catalin.marinas at arm.com>

Thanks.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20221114/f7944781/attachment-0001.sig>