[PATCH v4 2/8] arm64/fpsimd: Track the saved FPSIMD state type separately to TIF_SVE

Catalin Marinas catalin.marinas at arm.com
Sun Nov 13 14:12:12 PST 2022


On Sat, Oct 22, 2022 at 12:03:15AM +0100, Mark Brown wrote:
> diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
> index 445aa3af3b76..3cce0a4c4e8d 100644
> --- a/arch/arm64/include/asm/processor.h
> +++ b/arch/arm64/include/asm/processor.h
> @@ -122,6 +122,11 @@ enum vec_type {
>  	ARM64_VEC_MAX,
>  };
>  
> +enum fp_type {
> +	FP_STATE_FPSIMD,
> +	FP_STATE_SVE,
> +};

More of a nitpick, I still find the type/state naming confusing but I
don't have a better suggestion. Maybe call them FP_TYPE_* or rename the
enum to fp_state_type (up to you really, feel free to leave them as they
are).

Either way, I think having an explicit type of what state is about is a
significant improvement in clarity.

Reviewed-by: Catalin Marinas <catalin.marinas at arm.com>



More information about the linux-arm-kernel mailing list