[PATCH] phy: freescale: imx8m-pcie: Handle IMX8_PCIE_REFCLK_PAD_UNUSED

Marek Vasut marex at denx.de
Mon Mar 14 03:52:40 PDT 2022


On 3/14/22 04:29, Hongxing Zhu wrote:

[...]

>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>> Hi Marek:
>>> Thanks for your patch.
>>> I assume that you had tested this IMX8_PCIE_REFCLK_PAD_UNUSED option.
>>
>> Yes
>>
>>> The CLK_N/P pads are not connected on the tested board, right?
>>
>> They are connected from MX8MP SoC to MiniPCIe slot.
>> There is no external clock source like on the EVK, the MX8MP internal PLL is
>> the clock source.
>>
> Got that, thanks.

btw. if you plan to resend the MX8MP PCIe patches (assuming they didn't 
get applied yet), CC me, I can provide a Tested-by .

>>> BTW, it's better to add the Fixes tag into the commit log.
>>
>> Do you think this should be considered a bugfix ?
> Emm...
> It's reasonable to consider it as new added.
> Okay, I'm fine with it. Thanks again for your patch.
> 
> Reviewed-by: Richard Zhu <hongxing.zhu at nxp.com>

Let's wait for others' opinion, I'm really unsure whether this is a 
Fixes: or not.



More information about the linux-arm-kernel mailing list