[PATCH] soc: brcmstb: pm: Add of_node_put() when the iteration breaks
Liang He
windhl at 126.com
Tue Jul 5 04:28:15 PDT 2022
In brcmstb_pm_probe(), we should call of_node_put() when the
for_each_matching_node() iteration breaks as the for_each_xx OF
APIs will automatically increase and decrease the refcount in
each iteration.
Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)")
Signed-off-by: Liang He <windhl at 126.com>
---
Patched file has been compiled test in 5.19rc5.
drivers/soc/bcm/brcmstb/pm/pm-arm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soc/bcm/brcmstb/pm/pm-arm.c b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
index 70ad0f3dce28..f5573d6efae3 100644
--- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c
+++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c
@@ -732,11 +732,13 @@ static int brcmstb_pm_probe(struct platform_device *pdev)
i = ctrl.num_memc;
if (i >= MAX_NUM_MEMC) {
pr_warn("too many MEMCs (max %d)\n", MAX_NUM_MEMC);
+ of_node_put(dn);
break;
}
base = of_io_request_and_map(dn, 0, dn->full_name);
if (IS_ERR(base)) {
+ of_node_put(dn);
if (!ctrl.support_warm_boot)
break;
@@ -752,12 +754,14 @@ static int brcmstb_pm_probe(struct platform_device *pdev)
for_each_matching_node(dn, brcmstb_memc_of_match) {
base = of_iomap(dn, 0);
if (!base) {
+ of_node_put(dn);
pr_err("error mapping DDR Sequencer %d\n", i);
return -ENOMEM;
}
of_id = of_match_node(brcmstb_memc_of_match, dn);
if (!of_id) {
+ of_node_put(dn);
iounmap(base);
return -EINVAL;
}
--
2.25.1
More information about the linux-arm-kernel
mailing list