[EXT] Re: [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item

[Wei Fang]

Hi Krzysztof,
	
	Sorry, I'm still a little confused. Do you mean to modify as follows?
> +      - items:
> +          - enum:
> +              - fsl,imx8ulp-fec
> +          - const: fsl,imx6ul-fec
> +          - const: fsl,imx6q-fec

And as far as I know, the imx8ulp's fec is reused from imx6ul, they both have the same features. However, the fec of imx8ulp(and imx6ul) is a little different from imx6q, therefore, the functions supported by the driver are also somewhat different. 

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> 
Sent: 2022年7月4日 17:12
To: Wei Fang <wei.fang at nxp.com>; davem at davemloft.net; edumazet at google.com; kuba at kernel.org; pabeni at redhat.com; robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org; shawnguo at kernel.org; s.hauer at pengutronix.de
Cc: netdev at vger.kernel.org; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; kernel at pengutronix.de; festevam at gmail.com; dl-linux-imx <linux-imx at nxp.com>; Peng Fan <peng.fan at nxp.com>; Jacky Bai <ping.bai at nxp.com>; sudeep.holla at arm.com; linux-arm-kernel at lists.infradead.org; Aisheng Dong <aisheng.dong at nxp.com>
Subject: [EXT] Re: [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item

Caution: EXT Email

On 04/07/2022 12:10, Wei Fang wrote:
> Add compatible item for i.MX8ULP platform.

Wrong subject prefix (dt-bindings).

Wrong subject contents - do not use some generic sentences like "update X", just write what you are doing or what you want to achieve. For example:
dt-bindings: net: fsl,fec: add i.MX8 ULP FEC

>
> Signed-off-by: Wei Fang <wei.fang at nxp.com>
> ---
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml 
> b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..6642c246951b 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -40,6 +40,10 @@ properties:
>            - enum:
>                - fsl,imx7d-fec
>            - const: fsl,imx6sx-fec
> +      - items:
> +          - enum:
> +              - fsl,imx8ulp-fec
> +          - const: fsl,imx6ul-fec

This is wrong.  fsl,imx6ul-fec has to be followed by fsl,imx6q-fec. I think someone made similar mistakes earlier so this is a mess.

>        - items:
>            - const: fsl,imx8mq-fec
>            - const: fsl,imx6sx-fec


Best regards,
Krzysztof