[PATCH 1/3] dt-bings: net: fsl,fec: update compatible item
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Mon Jul 4 02:12:09 PDT 2022
On 04/07/2022 12:10, Wei Fang wrote:
> Add compatible item for i.MX8ULP platform.
Wrong subject prefix (dt-bindings).
Wrong subject contents - do not use some generic sentences like "update
X", just write what you are doing or what you want to achieve. For example:
dt-bindings: net: fsl,fec: add i.MX8 ULP FEC
>
> Signed-off-by: Wei Fang <wei.fang at nxp.com>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..6642c246951b 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -40,6 +40,10 @@ properties:
> - enum:
> - fsl,imx7d-fec
> - const: fsl,imx6sx-fec
> + - items:
> + - enum:
> + - fsl,imx8ulp-fec
> + - const: fsl,imx6ul-fec
This is wrong. fsl,imx6ul-fec has to be followed by fsl,imx6q-fec. I
think someone made similar mistakes earlier so this is a mess.
> - items:
> - const: fsl,imx8mq-fec
> - const: fsl,imx6sx-fec
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list