[PATCH v7 6/8] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback

[Hongxing Zhu]

> -----Original Message-----
> From: Bjorn Helgaas <helgaas at kernel.org>
> Sent: 2022年2月24日 1:50
> To: Hongxing Zhu <hongxing.zhu at nxp.com>
> Cc: l.stach at pengutronix.de; bhelgaas at google.com; broonie at kernel.org;
> lorenzo.pieralisi at arm.com; jingoohan1 at gmail.com; festevam at gmail.com;
> francesco.dolcini at toradex.com; linux-pci at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> kernel at pengutronix.de; dl-linux-imx <linux-imx at nxp.com>
> Subject: Re: [PATCH v7 6/8] PCI: dwc: Add dw_pcie_host_ops.host_exit()
> callback
> 
> On Wed, Feb 16, 2022 at 02:21:01PM +0800, Richard Zhu wrote:
> > When link is never came up in the link training after host_init.
> > The clocks and power supplies usage counter balance should be handled
> > properly on some DWC platforms (for example, i.MX PCIe).
> >
> > Add a new host_exit() callback into dw_pcie_host_ops, then it could be
> > invoked to handle the unbalance issue in the error handling after
> > host_init() function when link is down.
> 
> Possible rewording, not sure if it captures everything you want:
> 
>   When the link never comes up after ->host_init(), some drivers,
>   especially those that don't support hotplug, want to turn off clocks
>   and power supplies.
> 
>   Add a new ->host_exit() callback in dw_pcie_host_ops so these
>   drivers can clean up if ->host_init() fails.

Thanks, it's more detailed, and easier understand. Would be updated later.

Best Regards
Richard Zhu