[PATCH] ARM: OMAP4: PM: update ROM return address for OSWR and OFF

[Tony Lindgren]

* Tony Lindgren <tony at atomide.com> [210314 18:42]:
> +static int __init secure_pm_init(void)
> +{
> +	if (omap_type() == OMAP2_DEVICE_TYPE_GP)
> +		return 0;
> +
> +	cpu_pm_register_notifier(&secure_notifier_block);
> +
> +	return 0;
> +}
> +omap_arch_initcall(secure_pm_init);

Testing my branches on various boards shows that n900 does not like this, it
needs to be limited to omap4 only. Using updated patch below instead.

Regards,

Tony

8< ------------------------------
>From tony Mon Sep 17 00:00:00 2001
From: Carlos Leija <cileija at ti.com>
Date: Sun, 14 Mar 2021 18:35:44 +0200
Subject: [PATCH] ARM: OMAP4: PM: update ROM return address for OSWR and
 OFF

We need to add a dummy smc call to the cpuidle wakeup path to force the
ROM code to save the return address after MMU is enabled again. This is
needed to prevent random hangs on secure devices like droid4.

Otherwise the system will eventually hang when entering deeper SoC idle
states with the core and mpu domains in open-switch retention (OSWR).
The hang happens as the ROM code tries to use the earlier physical return
address set by omap-headsmp.S with MMU off while waking up CPU1 again.

The hangs started happening in theory already with commit caf8c87d7ff2
("ARM: OMAP2+: Allow core oswr for omap4"), but in practise the issue went
unnoticed as various drivers were often blocking any deeper idle states
with hardware autoidle features.

This patch is based on an earlier TI Linux kernel tree commit 92f0b3028d9e
("OMAP4: PM: update ROM return address for OSWR and OFF") written by
Carlos Leija <cileija at ti.com>, Praneeth Bajjuri <praneeth at ti.com>, and
Bryan Buckley <bryan.buckley at ti.com>. A later version of the patch was
updated to use CPU_PM notifiers by Tero Kristo <t-kristo at ti.com>.

Signed-off-by: Carlos Leija <cileija at ti.com>
Signed-off-by: Praneeth Bajjuri <praneeth at ti.com>
Signed-off-by: Bryan Buckley <bryan.buckley at ti.com>
Signed-off-by: Tero Kristo <t-kristo at ti.com>
Fixes: caf8c87d7ff2 ("ARM: OMAP2+: Allow core oswr for omap4")
Reported-by: Carl Philipp Klemm <philipp at uvos.xyz>
Reported-by: Merlijn Wajer <merlijn at wizzup.org>
Cc: Ivan Jelincic <parazyd at dyne.org>
Cc: Pavel Machek <pavel at ucw.cz>
Cc: Sebastian Reichel <sre at kernel.org>
Cc: Tero Kristo <kristo at kernel.org>
[tony at atomide.com: updated to apply, updated description]
Signed-off-by: Tony Lindgren <tony at atomide.com>
---
 arch/arm/mach-omap2/omap-secure.c | 39 +++++++++++++++++++++++++++++++
 arch/arm/mach-omap2/omap-secure.h |  1 +
 2 files changed, 40 insertions(+)

diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
--- a/arch/arm/mach-omap2/omap-secure.c
+++ b/arch/arm/mach-omap2/omap-secure.c
@@ -9,6 +9,7 @@
  */
 
 #include <linux/arm-smccc.h>
+#include <linux/cpu_pm.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/io.h>
@@ -20,6 +21,7 @@
 
 #include "common.h"
 #include "omap-secure.h"
+#include "soc.h"
 
 static phys_addr_t omap_secure_memblock_base;
 
@@ -213,3 +215,40 @@ void __init omap_secure_init(void)
 {
 	omap_optee_init_check();
 }
+
+/*
+ * Dummy dispatcher call after core OSWR and MPU off. Updates the ROM return
+ * address after MMU has been re-enabled after CPU1 has been woken up again.
+ * Otherwise the ROM code will attempt to use the earlier physical return
+ * address that got set with MMU off when waking up CPU1. Only used on secure
+ * devices.
+ */
+static int cpu_notifier(struct notifier_block *nb, unsigned long cmd, void *v)
+{
+	switch (cmd) {
+	case CPU_CLUSTER_PM_EXIT:
+		omap_secure_dispatcher(OMAP4_PPA_SERVICE_0,
+				       FLAG_START_CRITICAL,
+				       0, 0, 0, 0, 0);
+		break;
+	default:
+		break;
+	}
+
+	return NOTIFY_OK;
+}
+
+static struct notifier_block secure_notifier_block = {
+	.notifier_call = cpu_notifier,
+};
+
+static int __init secure_pm_init(void)
+{
+	if (omap_type() == OMAP2_DEVICE_TYPE_GP || !soc_is_omap44xx())
+		return 0;
+
+	cpu_pm_register_notifier(&secure_notifier_block);
+
+	return 0;
+}
+omap_arch_initcall(secure_pm_init);
diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h
--- a/arch/arm/mach-omap2/omap-secure.h
+++ b/arch/arm/mach-omap2/omap-secure.h
@@ -50,6 +50,7 @@
 #define OMAP5_DRA7_MON_SET_ACR_INDEX	0x107
 
 /* Secure PPA(Primary Protected Application) APIs */
+#define OMAP4_PPA_SERVICE_0		0x21
 #define OMAP4_PPA_L2_POR_INDEX		0x23
 #define OMAP4_PPA_CPU_ACTRL_SMP_INDEX	0x25
 
-- 
2.30.2