[PATCH v2] ARM: dts: ixp4xx: Add Arcom Vulcan device tree

[Linus Walleij]

On Tue, Jul 27, 2021 at 8:44 PM Marc Zyngier <maz at kernel.org> wrote:

> Thanks a lot for doing this. I'm slowly getting this box up and
> running again, and noticed a couple of issues with the DT, see below.

Hey :)

Do you want me to do my best to fix it up or will you send me
a patch on top I can just fold in to get it the way you want it?

> > +                      */
> > +                     interrupt-map =
> > +                     /* IDSEL 1 */
> > +                     <0x0800 0 0 1 &gpio0 2 3>, /* INT A on slot 1 is irq 2 */
> > +                     <0x0800 0 0 2 &gpio0 2 3>, /* INT B on slot 1 is irq 2 */
> > +                     <0x0800 0 0 3 &gpio0 2 3>, /* INT C on slot 1 is irq 2 */
> > +                     <0x0800 0 0 4 &gpio0 2 3>, /* INT D on slot 1 is irq 2 */
> > +                     /* IDSEL 2 */
> > +                     <0x1000 0 0 1 &gpio0 3 3>, /* INT A on slot 2 is irq 3 */
> > +                     <0x1000 0 0 2 &gpio0 3 3>, /* INT B on slot 2 is irq 3 */
> > +                     <0x1000 0 0 3 &gpio0 3 3>, /* INT C on slot 2 is irq 3 */
> > +                     <0x1000 0 0 4 &gpio0 3 3>; /* INT D on slot 2 is irq 3 */
>
> All the intspecs should describe a LEVEL_LOW interrupt. What you have
> here isn't even legal... ;-)

Nobody understands these maps. I made them all wrong, so I'll go over
them all.

Yours,
Linus Walleij