[PATCH] pwm: atmel: rework tracking updates pending in hardware

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Jul 5 00:55:47 PDT 2021


Hello Thierry,

On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-König wrote:
> This improves the driver's behavior in several ways:
> 
>  - The lock is held for shorter periods and so a channel that is currently
>    waited for doesn't block disabling another channel.
> 
>  - It's easier to understand because the procedure is split into more
>    semantic units and documentation is improved
> 
>  - A channel is only set to pending when such an event is actually
>    scheduled in hardware (by writing the CUPD register).
> 
>  - Also wait in .get_state() to report the last configured state instead
>    of (maybe) the previous one. This fixes the read back duty cycle and so
>    prevents a warning being emitted when PWM_DEBUG is on.
> 
> Tested on an AriettaG25.

On patchwork this patch is in the state "Under Review". Did you change
this? What does this mean? Does indeed someone look into this patch?

There was some discussion in reply to this patch, but that doesn't
affect correctness of it. It's just that there are still some problems
in the driver that this patch doesn't address, but the net effect of it
is still positive.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20210705/dea44229/attachment.sig>


More information about the linux-arm-kernel mailing list