[PATCH] PCI: mediatek: Add missing of_node_put() to fix reference leak

Lorenzo Pieralisi lorenzo.pieralisi at arm.com
Mon Jan 25 12:34:33 EST 2021


On Wed, 20 Jan 2021 18:48:10 +0000, Krzysztof Wilczyński wrote:
> The for_each_available_child_of_node helper internally makes use of the
> of_get_next_available_child() which performs an of_node_get() on each
> iteration when searching for next available child node.
> 
> Should an available child node be found, then it would return a device
> node pointer with reference count incremented, thus early return from
> the middle of the loop requires an explicit of_node_put() to prevent
> reference count leak.
> 
> [...]

Applied to pci/mediatek, thanks!

[1/1] PCI: mediatek: Add missing of_node_put() to fix reference leak
      https://git.kernel.org/lpieralisi/pci/c/42814c438a

Thanks,
Lorenzo



More information about the linux-arm-kernel mailing list