[PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible

[Laurent Pinchart]

Hi Chen-Yu,

On Mon, Jan 18, 2021 at 06:22:15PM +0800, Chen-Yu Tsai wrote:
> On Mon, Jan 18, 2021 at 6:03 PM Maxime Ripard <maxime at cerno.tech> wrote:
> > On Fri, Jan 15, 2021 at 09:16:30AM +0200, Laurent Pinchart wrote:
> > > On Thu, Jan 14, 2021 at 12:35:23PM +0100, Maxime Ripard wrote:
> > > > The corpro,gm7123 was in use in a DT but was never properly documented,
> > > > let's add it.
> > > >
> > > > Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> > > > Cc: Sam Ravnborg <sam at ravnborg.org>
> > > > Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> > > > ---
> > > >  .../devicetree/bindings/display/bridge/simple-bridge.yaml     | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > index 64e8a1c24b40..97ca07b56cbc 100644
> > > > --- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
> > > > @@ -22,6 +22,10 @@ properties:
> > > >                - ti,ths8134a
> > > >                - ti,ths8134b
> > > >            - const: ti,ths8134
> > > > +      - items:
> > > > +          - const: corpro,gm7123
> > > > +          - const: adi,adv7123
> > >
> > > Do we need adi,adv7123 ?
> >
> > I'm not sure: it looks like having both the adv7123 and the dumb-vga-dac
> > compatible was never an option, so we can also change the DT to have
> > corpro,gm7123, dumb-vga-dac
> 
> FYI I used the adi,adv7123 fallback because the gm7123 datasheet compares
> the two, with the gm7123 having lower standby current, but only limited to
> 3.3V power supply. Maximum resolution, conversion rate, and the range of
> output current are all the same. The package is the same as well. I
> believe the gm7123 is intended as a drop-in clone of the adv7123.

That's a good point. I don't mind either way.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

-- 
Regards,

Laurent Pinchart