[PATCH 01/10] usb: gadget: udc: bcm63xx: fix deferred probing

Sergey Shtylyov s.shtylyov at omp.ru
Fri Dec 10 11:53:28 PST 2021


On 10/27/21 12:33 AM, Florian Fainelli wrote:

>> The driver overrides the error codes returned by platform_get_irq() to
>> -ENXIO for some strange reason, so if it returns -EPROBE_DEFER, the driver
>> will fail the probe permanently instead of the deferred probing. Switch to
>> propagating the error codes upstream.
>>
>> Fixes: 613065e53cb1 ("usb: gadget: bcm63xx UDC driver")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov at omp.ru>
> 
> Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>
> 
> Not that this is going to happen for this particular driver on the
> platform where it is use MIPS BCM63XX

   Thanks for noting that. I think I should re-qualify this patch from
a bug fix to cleanup. I'll split the series into 2 parts now.

> but this is still the right thing
> to do anyway.

   Yes, propagating the error is the Right Thing. :-)

MBR, Sergey



More information about the linux-arm-kernel mailing list