[PATCH 2/2] irqchip: nvic: Use GENERIC_IRQ_MULTI_HANDLER

[Vladimir Murzin]

On 12/1/21 2:05 PM, Arnd Bergmann wrote:
> On Wed, Dec 1, 2021 at 2:43 PM Vladimir Murzin <vladimir.murzin at arm.com> wrote:
>> On 12/1/21 12:30 PM, Arnd Bergmann wrote:
>>> On Wed, Dec 1, 2021 at 12:02 PM Vladimir Murzin <vladimir.murzin at arm.com> wrote:
>>>>
>>>> Rather then restructuring the ARMv7M entrly logic per TODO, just move
>>>> NVIC to GENERIC_IRQ_MULTI_HANDLER.
>>>>
>>>> Signed-off-by: Vladimir Murzin <vladimir.murzin at arm.com>
>>>
>>> Acked-by: Arnd Bergmann <arnd at arndb.de>
>>>
>>> Thanks for finishing this one off as well! I don't know if you did this as a
>>> reaction to me doing the same for the three other platforms that don't
>>> use GENERIC_IRQ_MULTI_HANDLER yet[1], or if this was just a lucky
>>> coincidence. It sounds like this should be part of Ard's IRQ stack series
>>> as well then (adding him to Cc), as it fits in with my patches there.
>>
>> It was reaction to Mark's TODO statement in his original submission [1].
>> I'd let maintainers to decide on the path it should land :)
> 
> Ah, nice, so it was a coincidence after all. I guess my patches were easier
> because of Mark's (and Marc's) earlier work on related bits.
> 
>>> Would you mind also implementing and testing the missing bits
>>> for the stack switching on nommu irq entry, corresponding to [2] so
>>> we can just use that part unconditionally as well?
>>
>> I can have a look but no promises since I have few issues with NOMMU
>> ATM (one of them seems to be cross-arch [2])
> 
> Yes, I saw that, but I'm not too worried about this on Arm, as we don't
> support that combination (SMP without MMU) in any of our platforms or
> in Kconfig without additional patches.

That's true, yet it seems to be broken for other arches which seems to be
supported (w/o additional patches?)

> 
> What target are you actually testing on?
> 

It is MPS3 board with range of FPGA images. M and R class supported yet
AN536 (Cortex-R52x2) has issues which prevents it using in SMP; recent 
images for M class require new timer (which is WIP).

I also have access to Fast Models - they are easier and quicker to test
and do not require visiting office :)

[1] https://developer.arm.com/tools-and-software/development-boards/fpga-prototyping-boards/download-fpga-images

Cheers
Vladimir

>        Arnd
>