[PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

[Nobuhiro Iwamatsu]

Hi,

On Sat, Apr 10, 2021 at 03:56:58PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote:
> > > > +static int visconti_pwm_remove(struct platform_device *pdev)
> > > > +{
> > > > +	struct visconti_pwm_chip *priv = platform_get_drvdata(pdev);
> > > > +
> > > > +	return pwmchip_remove(&priv->chip);
> > > 
> > > I think Uwe would prefer this to be done separately because he's working
> > > towards removing the return value from pwmchip_remove() and if we start
> > > ignoring it in new drivers that will make life easier going forward.
> > > 
> > > So this should just be:
> > > 
> > > 	pwmchip_remove(&priv->chip);
> > > 
> > > 	return 0;
> > 
> > I understand your suggestion.
> > However, it looks like the pwmchip_remove() hasn't been updated yet.
> > I will wait for the update of pwmchip_remove.
> 
> pwmchip_remove will always return 0 since b2c200e3f2fd which is in v5.3.
> So Thierry's suggestion is safe and indeed welcome.

Sorry, I was looking at a different function.
I will fix this.

Best regards,
  Nobuhiro