[PATCH 2/7] ARM: shmobile: r8a7779: Use ioremap() to map INTC2 registers

Geert Uytterhoeven geert at linux-m68k.org
Tue Nov 17 09:19:27 EST 2020


Hi Arnd,

On Tue, Nov 17, 2020 at 1:25 PM Arnd Bergmann <arnd at kernel.org> wrote:
> On Tue, Nov 17, 2020 at 11:30 AM Geert Uytterhoeven
> <geert+renesas at glider.be> wrote:
> > Replace using the legacy IOMEM() macro to map various registers related
> > to INTC2 configuration by ioremap().
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
>
> The patch looks good, but since you are already touching these __raw_writel(),
> could you turn them into normal writel() to have a chance that this works
> on big-endian? It could be either a follow-up or merged into the same patch.

(Do you want us to support big-endian on these old platforms? ;-)

At your service. Seems to work well.

Note that there are a few more (arch/arm/mach-shmobile/platsmp-scu.c
and arch/arm/mach-shmobile/setup-r8a7778.c).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list