[PATCH 2/7] ARM: shmobile: r8a7779: Use ioremap() to map INTC2 registers

Arnd Bergmann arnd at kernel.org
Tue Nov 17 07:25:26 EST 2020


On Tue, Nov 17, 2020 at 11:30 AM Geert Uytterhoeven
<geert+renesas at glider.be> wrote:
>
> Replace using the legacy IOMEM() macro to map various registers related
> to INTC2 configuration by ioremap().
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>

The patch looks good, but since you are already touching these __raw_writel(),
could you turn them into normal writel() to have a chance that this works
on big-endian? It could be either a follow-up or merged into the same patch.

       Arnd



More information about the linux-arm-kernel mailing list