[PATCH] ARM: dts: stm32: Fix TA3-GPIO-C key on STM32MP1 DHCOM PDK2

Alexandre Torgue alexandre.torgue at st.com
Mon Nov 9 08:03:15 EST 2020


Hi Marek

On 10/8/20 9:35 PM, Marek Vasut wrote:
> On the prototype DHCOM, the TA3-GPIO-C button was connected to pin PI11 of
> the STM32MP15xx, however on the production SoM this was changed to pin PG0
> to free up the IRQ line 11 for LAN8710i PHY IRQ. Update the connection in
> the DT. Since the IRQ line 0 is used for PMIC as well and cannot be shared
> with the button, make the button polled.
> 
> Fixes: 87cabf9405cb ("ARM: dts: stm32: Add GPIO keys for STM32MP1 DHCOM PDK2")
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Alexandre Torgue <alexandre.torgue at st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
> Cc: Patrice Chotard <patrice.chotard at st.com>
> Cc: Patrick Delaunay <patrick.delaunay at st.com>
> Cc: linux-stm32 at st-md-mailman.stormreply.com
> To: linux-arm-kernel at lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 17 ++++++++++-------
>   1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi
> index 5dff24e39af8..9a0a59678097 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi
> @@ -46,6 +46,16 @@
>   			linux,code = <KEY_A>;
>   			gpios = <&gpiof 3 GPIO_ACTIVE_LOW>;
>   		};
> +
> +		/*
> +		 * The EXTi IRQ line 0 is shared with PMIC,
> +		 * so mark this as polled GPIO key.
> +		 */
> +		button-2 {
> +			label = "TA3-GPIO-C";
> +			linux,code = <KEY_C>;
> +			gpios = <&gpiog 0 GPIO_ACTIVE_LOW>;
> +		};
>   	};
>   
>   	gpio-keys {
> @@ -59,13 +69,6 @@
>   			wakeup-source;
>   		};
>   
> -		button-2 {
> -			label = "TA3-GPIO-C";
> -			linux,code = <KEY_C>;
> -			gpios = <&gpioi 11 GPIO_ACTIVE_LOW>;
> -			wakeup-source;
> -		};
> -
>   		button-3 {
>   			label = "TA4-GPIO-D";
>   			linux,code = <KEY_D>;
> 

Applied on stm32-dt-for-v5.10-fixes.

regards
alex



More information about the linux-arm-kernel mailing list