[PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle

Florian Fainelli f.fainelli at gmail.com
Mon Jun 29 12:45:17 EDT 2020

On 6/29/2020 5:47 AM, Lee Jones wrote:
> 'duty' here is an unsigned int, thus checking for <0 will always
> evaluate to false.
> Fixes the following W=1 warning:
>  drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> Cc: Ray Jui <rjui at broadcom.com>
> Cc: Scott Branden <sbranden at broadcom.com>
> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy at broadcom.com>
> Cc: bcm-kernel-feedback-list at broadcom.com
> Cc: linux-pwm at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of
the define, if you also remove it you can add:

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>

More information about the linux-arm-kernel mailing list