[PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
Lee Jones
lee.jones at linaro.org
Mon Jun 29 08:47:49 EDT 2020
'duty' here is an unsigned int, thus checking for <0 will always
evaluate to false.
Fixes the following W=1 warning:
drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Cc: Ray Jui <rjui at broadcom.com>
Cc: Scott Branden <sbranden at broadcom.com>
Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy at broadcom.com>
Cc: bcm-kernel-feedback-list at broadcom.com
Cc: linux-pwm at vger.kernel.org
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
drivers/pwm/pwm-bcm-iproc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
index 1f829edd8ee70..46f0a45e9049c 100644
--- a/drivers/pwm/pwm-bcm-iproc.c
+++ b/drivers/pwm/pwm-bcm-iproc.c
@@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm,
value = rate * state->duty_cycle;
duty = div64_u64(value, div);
- if (period < IPROC_PWM_PERIOD_MIN ||
- duty < IPROC_PWM_DUTY_CYCLE_MIN)
+ if (period < IPROC_PWM_PERIOD_MIN)
return -EINVAL;
if (period <= IPROC_PWM_PERIOD_MAX &&
--
2.25.1
More information about the linux-arm-kernel
mailing list