[PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning

[Thomas Zimmermann]

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:
> Fix W=1 warning by deleting unused local variable.
> 
> v2:
>    - Updated subject (Lee)
> 
> v3:
>    - Return early in case of an error (Thomas)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Michal Januszewski <spock at gentoo.org>
> Cc: linux-fbdev at vger.kernel.org
> Cc: Lee Jones <lee.jones at linaro.org>

Acked-by: Thomas Zimmermann <tzimmermann at suse.de>

> ---
>   drivers/video/fbdev/uvesafb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index 6c9cfab39313..4df6772802d7 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
>   	task->t.regs.eax = 0x4f0a;
>   	task->t.regs.ebx = 0x0;
>   	err = uvesafb_exec(task);
> +	if (err)
> +		return err;
>   
>   	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
>   		par->pmi_setpal = par->ypan = 0;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201207/ac561abf/attachment.sig>