[PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning
Sam Ravnborg
sam at ravnborg.org
Sun Dec 6 14:02:38 EST 2020
Fix W=1 warning by deleting unused local variable.
v2:
- Updated subject (Lee)
v3:
- Return early in case of an error (Thomas)
Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
Cc: Michal Januszewski <spock at gentoo.org>
Cc: linux-fbdev at vger.kernel.org
Cc: Lee Jones <lee.jones at linaro.org>
---
drivers/video/fbdev/uvesafb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index 6c9cfab39313..4df6772802d7 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
task->t.regs.eax = 0x4f0a;
task->t.regs.ebx = 0x0;
err = uvesafb_exec(task);
+ if (err)
+ return err;
if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
par->pmi_setpal = par->ypan = 0;
--
2.27.0
More information about the linux-arm-kernel
mailing list