[PATCH v6 0/3] add support for Socionext SynQuacer I2C controller

Ard Biesheuvel ard.biesheuvel at linaro.org
Tue Apr 3 11:56:26 PDT 2018


On 3 April 2018 at 20:45, Wolfram Sang <wsa at the-dreams.de> wrote:
>
>> We don't have suspend/resume support yet for this SoC, so I haven't
>> been able to try that. Also, the clocks are fixed in this particular
>> implementation, so the clk_xxx() calls don't actually do anything.
>
> Then please remove that, too! Good that I asked...
>

OK

> Frankly, not nice to make me review untested code without mentioning
> that fact somewhere :(
>

My apologies. I simply didn't think to remove it - I didn't write the
code, I am just the one upstreaming it.

> BTW are you willing to maintain this driver? Then an entry for
> MAINTAINERS would be needed.
>

OK, I will add that as well.



More information about the linux-arm-kernel mailing list