[PATCH v6 0/3] add support for Socionext SynQuacer I2C controller

Wolfram Sang wsa at the-dreams.de
Tue Apr 3 11:45:59 PDT 2018


> We don't have suspend/resume support yet for this SoC, so I haven't
> been able to try that. Also, the clocks are fixed in this particular
> implementation, so the clk_xxx() calls don't actually do anything.

Then please remove that, too! Good that I asked...

Frankly, not nice to make me review untested code without mentioning
that fact somewhere :(

BTW are you willing to maintain this driver? Then an entry for
MAINTAINERS would be needed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180403/e82bfbf3/attachment.sig>


More information about the linux-arm-kernel mailing list