[EXT] [PATCH 1/2] arm64: dts: marvell: fix interrupt-map property for Armada CP110 master PCIe controller

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Sep 28 06:56:08 PDT 2017


Hello,

On Thu, 28 Sep 2017 13:18:40 +0000, Yehuda Yitschak wrote:

> That zero you removed is the "parent unit address" according to the "interrupt-map" documentation 
> 
> 	parent unit address  - The unit address in the domain of the interrupt parent. The number of 32-bit
> 			            cells required to specify this address is described by the #address-cells property of the node
> 			           pointed to by the interrupt-parent field.
> 
> Now,  the gic has #address-cells =  <0x1>
> And the icu has  #address-cells = <0x0>
> 
> So when switching to ICU, the parent unit address was no longer needed and should have been removed 

Indeed, you are completely right. I'll adjust the patch accordingly and
resend. Thanks for spotting this!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list