[PATCH] pinctrl: use non-devm kmalloc versions for free functions
Tejun Heo
tj at kernel.org
Thu May 11 07:45:26 PDT 2017
Hello,
On Thu, May 11, 2017 at 03:20:58PM +0100, Andre Przywara wrote:
> > Tejun, do I read your comments on the patch as an ACK?
>
> Tejun and I were wondering why we need this "create an array with the
> indices" in the first place. If we can just call radix_tree_delete()
> directly from the radix_tree_for_each_slot() loop, we can have a much
> better fix (omitting the memory allocation at all)
Yeah, it doesn't make sense to allocate to destroy a radix tree. It'd
be much better to cleanup the code so that it doesn't need allocation
in the first place.
Thanks.
--
tejun
More information about the linux-arm-kernel
mailing list