[PATCH 3/4] arm64: dts: marvell: Enable second SDHCI controller in Armada 37xx

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Jun 8 12:17:02 PDT 2017


Hello,

On Thu,  8 Jun 2017 18:51:24 +0200, Gregory CLEMENT wrote:

> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index 4d495ec39202..01a9c30be38d 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -292,6 +292,17 @@
>  				};
>  			};
>  
> +			sdhci1: sdhci at d0000 {
> +				compatible = "marvell,armada-3700-sdhci",
> +				"marvell,sdhci-xenon";

One more tab on this second line would be nice.

> +				reg = <0xd0000 0x300
> +				       0x1e808 0x4>;

I'd prefer:

				reg = <0xd0000 0x300>, <0x1e808 0x4>;

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list