[PATCH v4 1/2] power: reset: add linkstation-reset driver
gregory.clement at free-electrons.com
Thu Jan 26 07:28:11 PST 2017
On jeu., janv. 19 2017, Sebastian Reichel <sre at kernel.org> wrote:
> Hi Roger,
> On Wed, Jan 18, 2017 at 09:08:13PM +0900, Roger Shimizu wrote:
>> On Sun, Jan 8, 2017 at 12:04 AM, Roger Shimizu <rogershimizu at gmail.com> wrote:
>> > Buffalo Linkstation / KuroBox and their variants need magic command
>> > sending to UART1 to power-off.
>> > Power driver linkstation-reset implements the magic command and I/O
>> > routine, which come from files listed below:
>> > - arch/arm/mach-orion5x/kurobox_pro-setup.c
>> > - arch/arm/mach-orion5x/terastation_pro2-setup.c
>> I think there's not much concern regarding to this series.
>> Could you kindly help to apply this patch?
> Well you dropped the DT binding, but still introduce new DT
> properties. Since they are not documented without the binding
> I won't merge this. DT binding documentation is not optional.
> In other words: NAK on the binding effectively means NAK on
> the driver in its current state.
> If you want to see this merged rebase it to Rob's generic
> serial bindings  and help to support him getting everything
> into mainline ASAP. Currently the feedback seems to be quite
> positive, so I hope to see it merged for 4.11.
>  https://lwn.net/Articles/711794/ (current proposal from 2 days
What is te status for your series?
Do you plan sending a new version soon?
> -- Sebastian
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
More information about the linux-arm-kernel