[PATCH v4 1/2] power: reset: add linkstation-reset driver
sre at kernel.org
Wed Jan 18 20:43:28 PST 2017
On Wed, Jan 18, 2017 at 09:08:13PM +0900, Roger Shimizu wrote:
> On Sun, Jan 8, 2017 at 12:04 AM, Roger Shimizu <rogershimizu at gmail.com> wrote:
> > Buffalo Linkstation / KuroBox and their variants need magic command
> > sending to UART1 to power-off.
> > Power driver linkstation-reset implements the magic command and I/O
> > routine, which come from files listed below:
> > - arch/arm/mach-orion5x/kurobox_pro-setup.c
> > - arch/arm/mach-orion5x/terastation_pro2-setup.c
> I think there's not much concern regarding to this series.
> Could you kindly help to apply this patch?
Well you dropped the DT binding, but still introduce new DT
properties. Since they are not documented without the binding
I won't merge this. DT binding documentation is not optional.
In other words: NAK on the binding effectively means NAK on
the driver in its current state.
If you want to see this merged rebase it to Rob's generic
serial bindings  and help to support him getting everything
into mainline ASAP. Currently the feedback seems to be quite
positive, so I hope to see it merged for 4.11.
 https://lwn.net/Articles/711794/ (current proposal from 2 days ago)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the linux-arm-kernel